Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mamba fixes and cleaning #1262

Merged
merged 3 commits into from
Aug 27, 2024
Merged

mamba fixes and cleaning #1262

merged 3 commits into from
Aug 27, 2024

Conversation

jahatef
Copy link
Collaborator

@jahatef jahatef commented Aug 20, 2024

adds:

  • some common configs to mamba configs so they can be ran easier.
  • a fix to some mamba configs
  • bypasses some checks in arguments.py
  • an assertion error when mamba is missing packages instead of a warning message

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jahatef
❌ Jacob Hatef

Jacob Hatef seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jahatef
Copy link
Collaborator Author

jahatef commented Aug 24, 2024

removed the assertion message for now.

Quentin-Anthony
Quentin-Anthony approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@Quentin-Anthony Quentin-Anthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Quentin-Anthony Quentin-Anthony merged commit 591563d into main Aug 27, 2024
1 of 5 checks passed
@Quentin-Anthony Quentin-Anthony deleted the mamba-cleanup branch August 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haileyschoelkopf haileyschoelkopf haileyschoelkopf left review comments

@Quentin-Anthony Quentin-Anthony Quentin-Anthony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jahatef @CLAassistant @Quentin-Anthony @haileyschoelkopf